lkml.org 
[lkml]   [2022]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] ACPI: make remove callback of ACPI driver void
On Tue, Nov 15, 2022 at 10:00 PM Maximilian Luz <luzmaximilian@gmail.com> wrote:
>
> On 11/13/22 17:26, Dawei Li wrote:
> > For bus-based driver, device removal is implemented as:
> > 1 device_remove()->
> > 2 bus->remove()->
> > 3 driver->remove()
> >
> > Driver core needs no inform from callee(bus driver) about the
> > result of remove callback. In that case, commit fc7a6209d571
> > ("bus: Make remove callback return void") forces bus_type::remove
> > be void-returned.
> >
> > Now we have the situation that both 1 & 2 of calling chain are
> > void-returned, so it does not make much sense for 3(driver->remove)
> > to return non-void to its caller.
> >
> > So the basic idea behind this change is making remove() callback of
> > any bus-based driver to be void-returned.
> >
> > This change, for itself, is for device drivers based on acpi-bus.
> >
> > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > Acked-by: Lee Jones <lee@kernel.org>
> > Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> > Signed-off-by: Dawei Li <set_pte_at@outlook.com>
>
> Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> # for drivers/platform/surface/*

Applied as 6.2 material, thanks!

\
 
 \ /
  Last update: 2022-11-23 19:30    [W:0.058 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site