lkml.org 
[lkml]   [2022]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v8 06/13] x86/resctrl: Remove the init attribute for rdt_cpu_has()
    From
    Hi Reinette,


    On 11/22/22 18:13, Reinette Chatre wrote:
    > Hi Babu,
    >
    > On 11/4/2022 1:00 PM, Babu Moger wrote:
    >> The monitor code in resctrl/monitor.c needs to call rdt_cpu_has() to
    >> detect the monitor related features. It has the init attribute and
    >> cannot be called in non-init routines. Remove the init attribute and
    >> make it available for all the resctrl files.
    > I think this is the wrong way to go. The rdt_cpu_has() callers are
    > init code and they should rather get the __init attribute instead of
    > rdt_cpu_has() losing it.

    Ok. I will add __init  attribute to rdt_get_mon_l3_config. That should work.

    Thanks

    Babu

    \
     
     \ /
      Last update: 2022-11-23 18:50    [W:3.712 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site