lkml.org 
[lkml]   [2022]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [patch V2 13/17] timers: Split [try_to_]del_timer[_sync]() to prepare for shutdown mode
Date
On Tue, Nov 22 2022 at 15:04, Jacob Keller wrote:
> On 11/22/2022 9:45 AM, Thomas Gleixner wrote:
>> +int try_to_del_timer_sync(struct timer_list *timer)
>> +{
>> + return __try_to_del_timer_sync(timer);
>> +}
>> EXPORT_SYMBOL(try_to_del_timer_sync);
>>
>
>
> Its a bit odd to me that some patches refactor and replace functions
> with new variants all under timer_* namespace, but then we've left some
> of them available without that.
>
> Any reasoning behind this? I guess "try_*" is pretty clear and unlikely
> to get stolen by other code..?

Kinda. I renamed del_timer*() because that's the ones which we want to
substitute with timer_shutdown*() where possible and reasonable.

A larger timer namespace cleanup is subject to a follow up series.

Thanks,

tglx

\
 
 \ /
  Last update: 2022-11-23 18:06    [W:0.101 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site