Messages in this thread | | | Date | Thu, 24 Nov 2022 01:09:59 +0900 | Subject | Re: [PATCH v2 1/2] dt-bindings: spi: Add Socionext F_OSPI controller bindings | From | Kunihiko Hayashi <> |
| |
Hi Krzysztof,
Thank you for reviewing.
On 2022/11/23 18:33, Krzysztof Kozlowski wrote: > On 21/11/2022 02:47, Kunihiko Hayashi wrote: >> Add devicetree binding documentation for Socionext F_OSPI SPI flash >> controller. > > Subject: drop second, redundant "bindings".
Ah, ok. I didn't notice it. I'll remove it in next.
>> >> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> >> --- >> .../bindings/spi/socionext,f-ospi.yaml | 57 +++++++++++++++++++ >> 1 file changed, 57 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/spi/socionext,f-ospi.yaml >> >> diff --git a/Documentation/devicetree/bindings/spi/socionext,f-ospi.yaml >> b/Documentation/devicetree/bindings/spi/socionext,f-ospi.yaml >> new file mode 100644 >> index 000000000000..e04492c4fc84 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/spi/socionext,f-ospi.yaml >> @@ -0,0 +1,57 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: "http://devicetree.org/schemas/spi/socionext,f-ospi.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > Drop quotes from both lines.
I see. I'll keep it in mind.
>> + >> +title: Socionext F_OSPI controller >> + >> +description: | >> + The Socionext F_OSPI is a controller used to interface with flash >> + memories using the SPI communication interface. >> + >> +maintainers: >> + - Kunihiko Hayashi <hayashi.kunihiko@socionext.com> >> + >> +allOf: >> + - $ref: "spi-controller.yaml#" > > Drop quotes.
Ditto.
> With above: > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
I'll fix the above in v3.
Thank you,
--- Best Regards Kunihiko Hayashi
| |