lkml.org 
[lkml]   [2022]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 013/606] gpio: pcf857x: Convert to i2c's .probe_new()
    On Wed, Nov 23, 2022 at 10:48 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
    >
    > On Fri, Nov 18, 2022 at 11:46 PM Uwe Kleine-König <uwe@kleine-koenig.org> wrote:
    > >
    > > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    > >
    > > .probe_new() doesn't get the i2c_device_id * parameter, so determine
    > > that explicitly in the probe function.
    > >
    > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    > > ---
    > > drivers/gpio/gpio-pcf857x.c | 6 +++---
    > > 1 file changed, 3 insertions(+), 3 deletions(-)
    > >
    > > diff --git a/drivers/gpio/gpio-pcf857x.c b/drivers/gpio/gpio-pcf857x.c
    > > index e98ea47d7237..cec2f2c78255 100644
    > > --- a/drivers/gpio/gpio-pcf857x.c
    > > +++ b/drivers/gpio/gpio-pcf857x.c
    > > @@ -247,9 +247,9 @@ static const struct irq_chip pcf857x_irq_chip = {
    > >
    > > /*-------------------------------------------------------------------------*/
    > >
    > > -static int pcf857x_probe(struct i2c_client *client,
    > > - const struct i2c_device_id *id)
    > > +static int pcf857x_probe(struct i2c_client *client)
    > > {
    > > + const struct i2c_device_id *id = i2c_client_get_device_id(client);
    > > struct pcf857x_platform_data *pdata = dev_get_platdata(&client->dev);
    > > struct device_node *np = client->dev.of_node;
    > > struct pcf857x *gpio;
    > > @@ -422,7 +422,7 @@ static struct i2c_driver pcf857x_driver = {
    > > .name = "pcf857x",
    > > .of_match_table = of_match_ptr(pcf857x_of_table),
    > > },
    > > - .probe = pcf857x_probe,
    > > + .probe_new = pcf857x_probe,
    > > .remove = pcf857x_remove,
    > > .shutdown = pcf857x_shutdown,
    > > .id_table = pcf857x_id,
    > > --
    > > 2.38.1
    > >
    >
    > Applied, thanks!
    >
    > Bartosz

    Same story as with the other ones:

    Acked-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

    \
     
     \ /
      Last update: 2022-11-23 16:53    [W:4.250 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site