Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH] USB: disable all RNDIS protocol drivers | Date | Wed, 23 Nov 2022 17:21:01 +0200 |
| |
Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> The Microsoft RNDIS protocol is, as designed, insecure and vulnerable on > any system that uses it with untrusted hosts or devices. Because the > protocol is impossible to make secure, just disable all rndis drivers to > prevent anyone from using them again. > > Windows only needed this for XP and newer systems, Windows systems older > than that can use the normal USB class protocols instead, which do not > have these problems. > > Android has had this disabled for many years so there should not be any > real systems that still need this. > > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Eric Dumazet <edumazet@google.com> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Paolo Abeni <pabeni@redhat.com> > Cc: Kalle Valo <kvalo@kernel.org> > Cc: Oleksij Rempel <linux@rempel-privat.de> > Cc: "Maciej Żenczykowski" <maze@google.com> > Cc: Neil Armstrong <neil.armstrong@linaro.org> > Cc: Mauro Carvalho Chehab <mchehab@kernel.org> > Cc: Andrzej Pietrasiewicz <andrzejtp2010@gmail.com> > Cc: Jacopo Mondi <jacopo@jmondi.org> > Cc: "Łukasz Stelmach" <l.stelmach@samsung.com> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: linux-usb@vger.kernel.org > Cc: netdev@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-wireless@vger.kernel.org > Reported-by: Ilja Van Sprundel <ivansprundel@ioactive.com> > Reported-by: Joseph Tartaro <joseph.tartaro@ioactive.com> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > Note, I'll submit patches removing the individual drivers for later, but > that is more complex as unwinding the interaction between the CDC > networking and RNDIS drivers is tricky. For now, let's just disable all > of this code as it is not secure. > > I can take this through the USB tree if the networking maintainers have > no objection. I thought I had done this months ago, when the last round > of "there are bugs in the protocol!" reports happened at the end of > 2021, but forgot to do so, my fault. > > drivers/net/usb/Kconfig | 1 + > drivers/net/wireless/Kconfig | 1 +
For wireless:
Acked-by: Kalle Valo <kvalo@kernel.org>
Feel free to take this via your tree.
-- https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |