Messages in this thread | | | Date | Tue, 22 Nov 2022 17:56:11 +0100 | From | Greg KH <> | Subject | Re: [PATCH V2 1/5] tty: serial: fsl_lpuart: only enable Idle Line Interrupt for non-dma case |
| |
On Thu, Nov 10, 2022 at 04:17:24PM +0800, Sherry Sun wrote: > For the lpuart driver, the Idle Line Interrupt Enable now is only needed > for the CPU mode, so enable the UARTCTRL_ILIE at the correct place, and > clear it when shutdown. > > Also need to configure the suitable UARTCTRL_IDLECFG, now the value is > 0x7, represent 128 idle characters will trigger the Idle Line Interrupt. > > Signed-off-by: Sherry Sun <sherry.sun@nxp.com> > --- > Changes in V2: > 1. Use FIELD_PREP() and GENMASK() for easy access to UARTCTRL_IDLECFG > fields as suggested by Ilpo. > --- > drivers/tty/serial/fsl_lpuart.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-)
This commit breaks the build for me as FIELD_PREP() does not seem to be included properly :(
Please fix up and resend.
thanks,
greg k-h
| |