lkml.org 
[lkml]   [2022]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] usb: musb: remove extra check in musb_gadget_vbus_draw
On Mon, Nov 14, 2022 at 10:59:47AM +0200, Ivaylo Dimitrov wrote:
> The check for musb->xceiv->set_power duplicates the check done in
> usb_phy_set_power(). Moreover, not calling usb_phy_set_power() results in
> current USB config max current not being propagated through usb_charger FW

What does "FW" mean here?

>
> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> ---
> drivers/usb/musb/musb_gadget.c | 2 --
> 1 file changed, 2 deletions(-)

And is this a bugfix? If so, what commit id does it fix? Should it go
to stable kernels? What hardware was this tested on that this solved a
problem for?

Please fix this and send a v2.

thanks,

greg k-h

\
 
 \ /
  Last update: 2022-11-22 17:12    [W:0.088 / U:0.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site