lkml.org 
[lkml]   [2022]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 07/14] dt-bindings: clock: Add StarFive JH7110 system and always-on clock definitions
From
On 22/11/2022 02:02, Hal Feng wrote:
> On Mon, 21 Nov 2022 09:45:11 +0100, Krzysztof Kozlowski wrote:
>> On 18/11/2022 02:06, Hal Feng wrote:
>>> From: Emil Renner Berthing <kernel@esmil.dk>
>>>
>>> Add all clock outputs for the StarFive JH7110 system (SYS) and
>>> always-on (AON) clock generator.
>>>
>>> Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
>>> Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
>>> ---
>>> MAINTAINERS | 5 +-
>>> include/dt-bindings/clock/starfive-jh7110.h | 234 ++++++++++++++++++++
>>> 2 files changed, 237 insertions(+), 2 deletions(-)
>>> create mode 100644 include/dt-bindings/clock/starfive-jh7110.h
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index e6f1060e7964..e97dac9c0ee4 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -19598,12 +19598,13 @@ M: Ion Badulescu <ionut@badula.org>
>>> S: Odd Fixes
>>> F: drivers/net/ethernet/adaptec/starfire*
>>>
>>> -STARFIVE JH7100 CLOCK DRIVERS
>>> +STARFIVE CLOCK DRIVERS
>>> M: Emil Renner Berthing <kernel@esmil.dk>
>>> +M: Hal Feng <hal.feng@starfivetech.com>
>>> S: Maintained
>>> F: Documentation/devicetree/bindings/clock/starfive,jh7100-*.yaml
>>> F: drivers/clk/starfive/
>>> -F: include/dt-bindings/clock/starfive-jh7100*.h
>>> +F: include/dt-bindings/clock/starfive*
>>>
>>> STARFIVE JH7100 PINCTRL DRIVER
>>> M: Emil Renner Berthing <kernel@esmil.dk>
>>> diff --git a/include/dt-bindings/clock/starfive-jh7110.h b/include/dt-bindings/clock/starfive-jh7110.h
>>
>> Filename based / the same as compatible (or bindings filename).
>
> Should I split this file into two files for "SYSCRG" and "AONCRG", which
> maybe named as "starfive-jh7110-sys.h" and "starfive-jh7110-aon.h". Ditto
> for the patch 8.

Does not have to be, but anyway naming must follow compatible naming, so
vendor,soc-device.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-11-22 08:42    [W:0.132 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site