Messages in this thread | | | Date | Tue, 22 Nov 2022 16:48:45 +0100 | Subject | Re: [PATCH v28 01/11] dt-bindings: arm: mediatek: mmsys: add vdosys1 compatible for MT8195 | From | Matthias Brugger <> |
| |
On 22/11/2022 11:51, Nancy Lin (林欣螢) wrote: > Dear Matthias, > > Thanks for the review. > > On Thu, 2022-11-10 at 14:10 +0100, Matthias Brugger wrote: >> >> On 09/11/2022 06:10, Jason-JH Lin (林睿祥) wrote: >> > On Tue, 2022-11-08 at 18:46 +0100, Matthias Brugger wrote: >> > > >> > > On 07/11/2022 08:22, Nancy.Lin wrote: >> > > > Add vdosys1 mmsys compatible for MT8195 platform. >> > > > >> > > > For MT8195, VDOSYS0 and VDOSYS1 are 2 display HW pipelines >> > > > binding >> > > > to >> > > > 2 different power domains, different clock drivers and >> > > > different >> > > > mediatek-drm drivers. >> > > > >> > > > Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com> >> > > > Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> >> > > > --- >> > > > >> > > > .../devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml | >> > > > 4 >> > > > +++- >> > > > 1 file changed, 3 insertions(+), 1 deletion(-) >> > > > >> > > > diff --git >> > > > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys >> > > > .yam >> > > > l >> > > > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys >> > > > .yam >> > > > l >> > > > index 0711f1834fbd..aaabe2196185 100644 >> > > > --- >> > > > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys >> > > > .yam >> > > > l >> > > > +++ >> > > > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys >> > > > .yam >> > > > l >> > > > @@ -48,7 +48,9 @@ properties: >> > > > - const: syscon >> > > > >> > > > - items: >> > > > - - const: mediatek,mt8195-vdosys0 >> > > > + - enum: >> > > > + - mediatek,mt8195-vdosys0 >> > > > + - mediatek,mt8195-vdosys1 >> > > > - const: mediatek,mt8195-mmsys >> > > > - const: syscon >> > > > >> > > >> > > I think we had that several times already: >> > > >> > >> > > https://lore.kernel.org/all/6bbe9527-ae48-30e0-fb45-519223a744d7@linaro.org/ >> > > >> > > We will something like this, but please check that this does not >> > > give >> > > any >> > > errors/warnings: >> > > >> > > diff --git >> > > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.y >> > > aml >> > > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.y >> > > aml >> > > index eb451bec23d3d..8e9c4f4d7c389 100644 >> > > --- >> > > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.y >> > > aml >> > > +++ >> > > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.y >> > > aml >> > > @@ -32,13 +32,22 @@ properties: >> > > - mediatek,mt8183-mmsys >> > > - mediatek,mt8186-mmsys >> > > - mediatek,mt8192-mmsys >> > > - - mediatek,mt8195-mmsys >> > > - mediatek,mt8365-mmsys >> > > - const: syscon >> > > - items: >> > > - const: mediatek,mt7623-mmsys >> > > - const: mediatek,mt2701-mmsys >> > > - const: syscon >> > > + - items: >> > > + - const: mediatek,mt8195-vdosys0 >> > > + - const: syscon >> > > + - items: >> > > + - const: mediatek,mt8195-vdosys1 >> > > + - const: syscon >> > > + - items: >> > > + - const: mediatek,mt8195-mmsys >> > > + - const: syscon >> > > + deprecated: true >> > > >> > > reg: >> > > maxItems: 1 >> > >> > Hi Matthias, >> > >> > As the vdosys0 previous reviewed patch: >> > >> > > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/patch/20220927152704.12018-2-jason-jh.lin@mediatek.com/__;!!CTRNKA9wMg0ARbw!zRdbIyyAsfqob2kapMAcKYATAguhEV0x0qE5cTOAcWUNhzeAbMHzZoos_2QzUCxS$ >> > >> > Should I modify the vdosys0 items format like your example? >> > >> > Or should vdosys1 add items format like vdosys0's previous patch? >> > - items: >> > - const: mediatek,mt8195-vdosys1 >> > - const: mediatek,mt8195-mmsys >> > - const: syscon >> > >> >> No, vdosys1 must not have mediatek,mt8195-mmsys fallback. >> >> Regards, >> Matthias >> > > I will fix it and add the following vdosys1 binding base on [1]. > > - description: vdosys0 and vdosys1 are 2 display HW pipelines, > so mt8195 binding should be deprecated. > deprecated: true > items: > - const: mediatek,mt8195-mmsys > - const: syscon > - items: > - const: mediatek,mt7623-mmsys > - const: mediatek,mt2701-mmsys > - const: syscon > - items: > - const: mediatek,mt8195-vdosys0 > - const: mediatek,mt8195-mmsys > - const: syscon > + - items: > + - const: mediatek,mt8195-vdosys1 > + - const: syscon >
Looks good, thanks Matthias
> [1] > https://kernel.googlesource.com/pub/scm/linux/kernel/git/matthias.bgg/linux/+/b237efd47df7d25b78c306e90b97c5aa0ff4c4fc/Documentation/devicetree/bindings/arm/mediatek/mediatek%2Cmmsys.yaml > > Regards, > Nancy > > >> > Regards, >> > Jason-JH.Lin >> > >> > >> > >> > ************* MEDIATEK Confidentiality Notice >> > ******************** >> > The information contained in this e-mail message (including any >> > attachments) may be confidential, proprietary, privileged, or >> > otherwise >> > exempt from disclosure under applicable laws. It is intended to be >> > conveyed only to the designated recipient(s). Any use, >> > dissemination, >> > distribution, printing, retaining or copying of this e-mail >> > (including its >> > attachments) by unintended recipient(s) is strictly prohibited and >> > may >> > be unlawful. If you are not an intended recipient of this e-mail, >> > or believe >> > >> > that you have received this e-mail in error, please notify the >> > sender >> > immediately (by replying to this e-mail), delete any and all copies >> > of >> > this e-mail (including any attachments) from your system, and do >> > not >> > disclose the content of this e-mail to any other person. Thank you! >> >> > > ************* MEDIATEK Confidentiality Notice ******************** > The information contained in this e-mail message (including any > attachments) may be confidential, proprietary, privileged, or otherwise > exempt from disclosure under applicable laws. It is intended to be > conveyed only to the designated recipient(s). Any use, dissemination, > distribution, printing, retaining or copying of this e-mail (including its > attachments) by unintended recipient(s) is strictly prohibited and may > be unlawful. If you are not an intended recipient of this e-mail, or believe > that you have received this e-mail in error, please notify the sender > immediately (by replying to this e-mail), delete any and all copies of > this e-mail (including any attachments) from your system, and do not > disclose the content of this e-mail to any other person. Thank you!
| |