lkml.org 
[lkml]   [2022]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 6/6] zsmalloc: Implement writeback mechanism for zsmalloc
On (22/11/22 02:10), Johannes Weiner wrote:
> > Yes. "What if it would continue". Would it make sense to not
> > break on EAGAIN?
> >
> > while (total < pages) {
> > ret = zs_reclaim_page(pool);
> > if (ret == -EAGAIN)
> > continue;
> > if (ret < 0)
> > break;
> > total++;
> > }
> >
> > Then we don't need retry loop in zs_reclaim_page().
>
> But that's an indefinite busy-loop?

That would mean that all lru pages constantly have locked objects
and we can only make partial progress.

> I don't see what the problem with limited retrying in
> zs_reclaim_page() is. It's robust and has worked for years.

No problem with it, just asking.

\
 
 \ /
  Last update: 2022-11-22 08:19    [W:0.300 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site