Messages in this thread | | | Date | Tue, 22 Nov 2022 06:34:10 -0800 | From | Richard Cochran <> | Subject | Re: [RFC Patch net-next v2 1/8] net: ptp: add helper for one-step P2P clocks |
| |
On Mon, Nov 21, 2022 at 09:11:43PM +0530, Arun Ramadoss wrote: > +/** > + * ptp_header_update_correction - Update PTP header's correction field > + * @skb: packet buffer > + * @type: type of the packet (see ptp_classify_raw()) > + * @hdr: ptp header > + * @correction: new correction value > + * > + * This updates the correction field of a PTP header and updates the UDP > + * checksum (if UDP is used as transport). It is needed for hardware capable of > + * one-step P2P that does not already modify the correction field of Pdelay_Req > + * event messages on ingress. > + */
Does this really belong in the common PTP header?
Seems more like a driver/hardware specific workaround to me.
Thanks, Richard
| |