Messages in this thread | | | Date | Tue, 22 Nov 2022 12:33:42 +0100 | Subject | Re: [PATCH v1 1/4] dt-bindings: interrupt-controller: mediatek,cirq: Migrate to dt schema | From | Krzysztof Kozlowski <> |
| |
On 18/11/2022 11:06, AngeloGioacchino Del Regno wrote: > Migrate mediatek,cirq.txt to dt schema as mediatek,mtk-cirq.yaml. > While at it, I've also fixed some typos that were present in the > original txt binding, as it was suggesting that the compatible > string would have "mediatek,cirq" as compatible but, in reality, > that's supposed to be "mediatek,mtk-cirq" instead. > > Little rewording on property descriptions also happened for > them to be more concise. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > .../interrupt-controller/mediatek,cirq.txt | 33 --------- > .../mediatek,mtk-cirq.yaml | 70 +++++++++++++++++++ > 2 files changed, 70 insertions(+), 33 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/mediatek,cirq.txt > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/mediatek,mtk-cirq.yaml > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/mediatek,cirq.txt b/Documentation/devicetree/bindings/interrupt-controller/mediatek,cirq.txt > deleted file mode 100644 > index 5865f4f2c69d..000000000000 > --- a/Documentation/devicetree/bindings/interrupt-controller/mediatek,cirq.txt > +++ /dev/null > @@ -1,33 +0,0 @@ > -* Mediatek 27xx cirq > - > -In Mediatek SOCs, the CIRQ is a low power interrupt controller designed to > -work outside MCUSYS which comprises with Cortex-Ax cores,CCI and GIC. > -The external interrupts (outside MCUSYS) will feed through CIRQ and connect > -to GIC in MCUSYS. When CIRQ is enabled, it will record the edge-sensitive > -interrupts and generate a pulse signal to parent interrupt controller when > -flush command is executed. With CIRQ, MCUSYS can be completely turned off > -to improve the system power consumption without losing interrupts. > - > -Required properties: > -- compatible: should be one of > - - "mediatek,mt2701-cirq" for mt2701 CIRQ > - - "mediatek,mt8135-cirq" for mt8135 CIRQ > - - "mediatek,mt8173-cirq" for mt8173 CIRQ > - and "mediatek,cirq" as a fallback. > -- interrupt-controller : Identifies the node as an interrupt controller. > -- #interrupt-cells : Use the same format as specified by GIC in arm,gic.txt. > -- reg: Physical base address of the cirq registers and length of memory > - mapped region. > -- mediatek,ext-irq-range: Identifies external irq number range in different > - SOCs. > - > -Example: > - cirq: interrupt-controller@10204000 { > - compatible = "mediatek,mt2701-cirq", > - "mediatek,mtk-cirq"; > - interrupt-controller; > - #interrupt-cells = <3>; > - interrupt-parent = <&sysirq>; > - reg = <0 0x10204000 0 0x400>; > - mediatek,ext-irq-start = <32 200>; > - }; > diff --git a/Documentation/devicetree/bindings/interrupt-controller/mediatek,mtk-cirq.yaml b/Documentation/devicetree/bindings/interrupt-controller/mediatek,mtk-cirq.yaml > new file mode 100644 > index 000000000000..21e709169907 > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/mediatek,mtk-cirq.yaml > @@ -0,0 +1,70 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/interrupt-controller/mediatek,mtk-cirq.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek System Interrupt Controller > + > +maintainers: > + - Youlin Pei <youlin.pei@mediatek.com> > + > +description: > + In MediaTek SoCs, the CIRQ is a low power interrupt controller designed to > + work outside of MCUSYS which comprises with Cortex-Ax cores, CCI and GIC. > + The external interrupts (outside MCUSYS) will feed through CIRQ and connect > + to GIC in MCUSYS. When CIRQ is enabled, it will record the edge-sensitive > + interrupts and generate a pulse signal to parent interrupt controller when > + flush command is executed. With CIRQ, MCUSYS can be completely turned off > + to improve the system power consumption without losing interrupts. > + > + > +properties: > + compatible: > + items: > + - enum: > + - mediatek,mt2701-cirq > + - mediatek,mt8135-cirq > + - mediatek,mt8173-cirq > + - const: mediatek,mtk-cirq > + > + reg: > + maxItems: 1 > + description: Address and size of the CIRQ registers
Drop description, it's obvious.
> + > + '#interrupt-cells': > + const: 3 > + > + interrupt-controller: true > + > + mediatek,ext-irq-range: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + maxItems: 1
This points it's array..
> + items: > + items:
But this it's matrix.
> + - description: First CIRQ interrupt > + - description: Last CIRQ interrupt
I guess it you should be just array with only one "items:" keyword.
> + description: > + Identifies the range of external interrupts in different SoCs > +
Best regards, Krzysztof
| |