lkml.org 
[lkml]   [2022]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] can: can327: fix potential skb leak when netdev is down
Marc, Wolfgang,

Could you please include William's patch to can327, provided that you
see no issue with it?


Thanks :)

Max




On Tue, 22 Nov 2022 10:10:50 +0800
"Ziyang Xuan (William)" <william.xuanziyang@huawei.com> wrote:

> Hello,
>
> Gently ask.
>
> Is there any other problem? And can it be applied?
>
> Thanks.
>
> > (CC Vincent, he may be interested)
> >
> >
> > On Thu, 10 Nov 2022 14:14:37 +0800
> > Ziyang Xuan <william.xuanziyang@huawei.com> wrote:
> >
> >> Fix it by adding kfree_skb() in can327_feed_frame_to_netdev() when netdev
> >> is down. Not tested, just compiled.
> >
> > Looks correct to me, so:
> >
> > Reviewed-by: Max Staudt <max@enpas.org>
> >
> >
> > Thank you very much for finding and fixing this!
> >
> > Max
> >
> > .
> >

\
 
 \ /
  Last update: 2022-11-22 11:10    [W:0.415 / U:0.700 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site