Messages in this thread | | | Date | Tue, 22 Nov 2022 16:13:42 -0800 | Subject | Re: [PATCH v8 06/13] x86/resctrl: Remove the init attribute for rdt_cpu_has() | From | Reinette Chatre <> |
| |
Hi Babu,
On 11/4/2022 1:00 PM, Babu Moger wrote: > The monitor code in resctrl/monitor.c needs to call rdt_cpu_has() to > detect the monitor related features. It has the init attribute and > cannot be called in non-init routines. Remove the init attribute and > make it available for all the resctrl files.
I think this is the wrong way to go. The rdt_cpu_has() callers are init code and they should rather get the __init attribute instead of rdt_cpu_has() losing it.
Reinette
| |