Messages in this thread | | | Date | Tue, 22 Nov 2022 16:41:02 -0600 | From | Nishanth Menon <> | Subject | Re: [PATCH v6 0/2] soc: ti: k3-socinfo: Add module build support to the k3 socinfo driver |
| |
On 12:48-20221122, Kevin Hilman wrote: > Hi Nishanth, > > Nishanth Menon <nm@ti.com> writes: > > > Hi Nicolas Frayer, > > > > On Thu, 17 Nov 2022 10:54:17 +0100, Nicolas Frayer wrote: > >> In order for the TI K3 SoC info driver to be built as a module, the > >> following changes have been made: > >> - Converted memory allocations to devm and added the remove callback > >> - Added necessary code to build the driver as a module > >> > >> v2->v3: > >> dropped module conversion part of this series while other driver > >> dependencies on socinfo are worked out. > >> A dependency issue is introduced by changing subsys_initcall() > >> to module_platform_driver(). Some drivers using the socinfo information > >> probe before the socinfo driver itself and it makes their probe fail. > >> > >> [...] > > > > I have applied the following to branch ti-drivers-soc-next on [1]. > > Thank you! > > Sorry for the churn here, but I think these need to be reverted. > > We've discoverd some more complexities/issues when socinfo is modular, > and I think the socinfo core code needs some work before this can > actually work reliably for all socinfo users. > > Basically, I think we need to finish converting all the socinfo users to > modules before we can be sure of all the corner cases when socinfo > itself is a module. > > Sorry about this churn, but I think it's better to be a bit conservative > here and revert before this lands in mainline.
Understood, and thanks for the headsup and explanation offline (explains why I had'nt caught it in my regression checks). I have dropped the series (since we managed to catch it just in time before arnd picked it up), updated the next and send out a new PR.
-- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
| |