Messages in this thread | | | Date | Tue, 22 Nov 2022 15:39:35 -0700 | Subject | Re: [PATCH] leds: leds-wm831x-status: init chip_pdata before access | From | Shuah Khan <> |
| |
On 11/22/22 14:05, Pavel Machek wrote: > Hi! > >> wm831x_status_probe() accesses status from chip_pdata before >> initializing it. Fix it. >> >> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org> > > Does it? ARRAY_SIZE() will be compile-time constant, no? > > What is the bug? Did you test the code? >
Is ARRAY_SIZE() safe when accessing the status chip_pdata->status? I wasn't sure. If so, this change isn't necessary.
thanks, -- Shuah
| |