| Date | Tue, 22 Nov 2022 17:36:14 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH 07/11] cxl/mem: Trace Memory Module Event Record |
| |
On Thu, 10 Nov 2022 10:57:54 -0800 ira.weiny@intel.com wrote:
> static bool cxl_event_tracing_enabled(void) > { > return trace_cxl_generic_event_enabled() || > trace_cxl_general_media_enabled() || > - trace_cxl_dram_enabled(); > + trace_cxl_dram_enabled() || > + trace_cxl_memory_module_enabled(); > } >
My only concern with this patch set is that gcc may decide to not inline this function and you will lose the performance of the static branches provided by the trace_cxl_*enabled() functions.
Other than that, for patches 5-7 from a tracing perspective:
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
|