Messages in this thread | | | Date | Tue, 22 Nov 2022 14:20:08 -0800 | From | Dmitry Torokhov <> | Subject | Re: [PATCH] Input: stmpe-ts - drop obsolete dependency on COMPILE_TEST |
| |
On Mon, Nov 21, 2022 at 02:52:03PM +0100, Jean Delvare wrote: > Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it > is possible to test-build any driver which depends on OF on any > architecture by explicitly selecting OF. Therefore depending on > COMPILE_TEST as an alternative is no longer needed. > > It is actually better to always build such drivers with OF enabled, > so that the test builds are closer to how each driver will actually be > built on its intended target. Building them without OF may not test > much as the compiler will optimize out potentially large parts of the > code. In the worst case, this could even pop false positive warnings. > Dropping COMPILE_TEST here improves the quality of our testing and > avoids wasting time on non-existent issues. > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Applied, thank you.
-- Dmitry
| |