Messages in this thread | | | Date | Mon, 21 Nov 2022 09:21:58 -0500 | Subject | Re: [PATCH next] kbuild: add ability to make source rpm buildable using koji | From | Jonathan Toppins <> |
| |
On 11/13/22 08:33, Masahiro Yamada wrote: > On Tue, Oct 25, 2022 at 10:17 PM Jonathan Toppins <jtoppins@redhat.com> wrote: >> >> From: Ivan Vecera <ivecera@redhat.com> >> >> Changes: >> - added new target 'srcrpm-pkg' to generate source rpm >> - added required build tools to spec file >> - removed locally compiled host tools to force their re-compile >> >> Signed-off-by: Ivan Vecera <ivecera@redhat.com> >> Signed-off-by: Jonathan Toppins <jtoppins@redhat.com> > > > > I am fine with this patch. > > Just minor comments. > > > I noticed an inconsistency between > "--target $(UTS_MACHINE)-linux" in the rpm-pkg target and > "--target $(UTS_MACHINE)" in the srcrpm-pkg target. > > > I applied 6105e4f6511d6b383738be89efb99c607e158a29 > just a few months ago. > Is it better to make it consistent here?
Yes I can post a v2 that includes this change.
> > Actually, I do not know koji, also not sure if it is > important to mention it in the commit subject. > I just tested this patch by using 'rpmbuild' command > on my local machine.
koji (https://koji.fedoraproject.org/koji/) is the automated builder available to Fedora developers. With this patch a developer can produce an upstream kernel rpm rather easily.
> > [...] > > > -- > Best Regards > Masahiro Yamada >
| |