Messages in this thread | | | From | Linus Walleij <> | Date | Mon, 21 Nov 2022 14:30:30 +0100 | Subject | Re: [PATCH v5 1/3] gpio: loongson2ef: move driver to original location |
| |
On Mon, Nov 21, 2022 at 1:38 PM Yinbo Zhu <zhuyinbo@loongson.cn> wrote:
> This gpio driver doesn't cover CPU_LOONGSON64 platforms, because > of gpio address was wrong and I don't plan to support it thus > move this driver to arch/mips/loongson2ef/ so that I can drop the > shackles of the legacy driver and add a new driver that supports > dts/acpi to support LoongArch platforms. > > Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>
Don't do this, we spent a lot of time to collect drivers in in drivers/gpio this is counter to our ambitions to have the drivers under drivers/* and only arch code under arch/*.
Create a new file named loongson2-64bit.c or so and just ignore that this one exist is an option, as is actually integrating this driver properly.
Yours, Linus Walleij
| |