Messages in this thread | | | Date | Mon, 21 Nov 2022 12:49:20 +0100 | Subject | Re: [PATCH] ASoC: Intel: Skylake: Fix Kconfig dependency | From | Cezary Rojewski <> |
| |
On 2022-11-21 11:47 AM, lili.li@intel.com wrote: > From: Lili Li <lili.li@intel.com> > > Commit e4746d94d00c ("ASoC: Intel: Skylake: Introduce HDA codec init and > exit routines") introduced HDA codec init routine which depends on SND_HDA. > Select SND_SOC_HDAC_HDA unconditionally to fix following compile error: > ERROR: modpost: "snd_hda_codec_device_init" [sound/soc/intel/skylake/snd-soc-skl.ko] undefined! > > Fixes: e4746d94d00c ("ASoC: Intel: Skylake: Introduce HDA codec init and exit routines") > Reviewed-by: Junxiao Chang <junxiao.chang@intel.com> > Suggested-by: Cezary Rojewski <cezary.rojewski@intel.com> > Signed-off-by: Lili Li <lili.li@intel.com> > --- > sound/soc/intel/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig > index d2ca710ac3fa..ac799de4f7fd 100644 > --- a/sound/soc/intel/Kconfig > +++ b/sound/soc/intel/Kconfig > @@ -177,7 +177,7 @@ config SND_SOC_INTEL_SKYLAKE_COMMON > select SND_HDA_DSP_LOADER > select SND_SOC_TOPOLOGY > select SND_SOC_INTEL_SST > - select SND_SOC_HDAC_HDA if SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC > + select SND_SOC_HDAC_HDA > select SND_SOC_ACPI_INTEL_MATCH > select SND_INTEL_DSP_CONFIG > help
Thanks once again your for report and input.
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
| |