lkml.org 
[lkml]   [2022]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v1 1/9] dt-bindings: arm: Add support for DSB element
From
On 21/11/2022 08:21, Tao Zhang wrote:
> Add property "qcom,dsb-elem-size" to support DSB(Discrete Single
> Bit) element for TPDA. Specifies the DSB element size supported
> by each monitor connected to the aggregator on each port. Should
> be specified in pairs (port, dsb element size).
>
> Signed-off-by: Tao Zhang <quic_taozha@quicinc.com>
> ---
> Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml
> index c46ddea..e3b58b5 100644
> --- a/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml
> @@ -58,6 +58,13 @@ properties:
> minItems: 1
> maxItems: 2
>
> + qcom,dsb-elem-size:

minor nit: Couldn't this be qcom,dsb-element-size ? Its not too long
from what we have and is more meaningful.

Otherwise,

Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com>

> + description: |
> + Specifies the DSB element size supported by each monitor
> + connected to the aggregator on each port. Should be specified
> + in pairs (port, dsb element size).
> + $ref: /schemas/types.yaml#/definitions/uint32-matrix
> +
> clocks:
> maxItems: 1
>
> @@ -100,6 +107,8 @@ examples:
> compatible = "qcom,coresight-tpda", "arm,primecell";
> reg = <0x6004000 0x1000>;
>
> + qcom,dsb-elem-size = <0 32>;
> +
> clocks = <&aoss_qmp>;
> clock-names = "apb_pclk";
>

\
 
 \ /
  Last update: 2022-11-21 12:45    [W:0.141 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site