lkml.org 
[lkml]   [2022]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/5] driver core: pass a const * into of_device_uevent()
    Date
    of_device_uevent() does not modify the struct device * passed into it,
    so make it a const * to enforce this. Also the documentation for the
    function was really wrong so fix that up at the same time.

    Cc: Rob Herring <robh+dt@kernel.org>
    Cc: Frank Rowand <frowand.list@gmail.com>
    Cc: devicetree@vger.kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/of/device.c | 6 +++---
    include/linux/of_device.h | 4 ++--
    2 files changed, 5 insertions(+), 5 deletions(-)

    diff --git a/drivers/of/device.c b/drivers/of/device.c
    index 8cefe5a7d04e..c674a13c3055 100644
    --- a/drivers/of/device.c
    +++ b/drivers/of/device.c
    @@ -332,10 +332,10 @@ EXPORT_SYMBOL_GPL(of_device_modalias);

    /**
    * of_device_uevent - Display OF related uevent information
    - * @dev: Device to apply DMA configuration
    - * @env: Kernel object's userspace event reference
    + * @dev: Device to display the uevent information for
    + * @env: Kernel object's userspace event reference to fill up
    */
    -void of_device_uevent(struct device *dev, struct kobj_uevent_env *env)
    +void of_device_uevent(const struct device *dev, struct kobj_uevent_env *env)
    {
    const char *compat, *type;
    struct alias_prop *app;
    diff --git a/include/linux/of_device.h b/include/linux/of_device.h
    index 1a803e4335d3..ab7d557d541d 100644
    --- a/include/linux/of_device.h
    +++ b/include/linux/of_device.h
    @@ -35,7 +35,7 @@ extern const void *of_device_get_match_data(const struct device *dev);
    extern ssize_t of_device_modalias(struct device *dev, char *str, ssize_t len);
    extern int of_device_request_module(struct device *dev);

    -extern void of_device_uevent(struct device *dev, struct kobj_uevent_env *env);
    +extern void of_device_uevent(const struct device *dev, struct kobj_uevent_env *env);
    extern int of_device_uevent_modalias(struct device *dev, struct kobj_uevent_env *env);

    static inline struct device_node *of_cpu_device_node_get(int cpu)
    @@ -64,7 +64,7 @@ static inline int of_driver_match_device(struct device *dev,
    return 0;
    }

    -static inline void of_device_uevent(struct device *dev,
    +static inline void of_device_uevent(const struct device *dev,
    struct kobj_uevent_env *env) { }

    static inline const void *of_device_get_match_data(const struct device *dev)
    --
    2.38.1
    \
     
     \ /
      Last update: 2022-11-21 10:48    [W:2.316 / U:0.792 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site