lkml.org 
[lkml]   [2022]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 580/606] usb: typec: tcpm/tcpci: Convert to i2c's .probe_new()
    On Fri, Nov 18, 2022 at 11:45:14PM +0100, Uwe Kleine-König wrote:
    > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    >
    > The probe function doesn't make use of the i2c_device_id * parameter so it
    > can be trivially converted.
    >
    > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

    Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

    > ---
    > drivers/usb/typec/tcpm/tcpci.c | 5 ++---
    > 1 file changed, 2 insertions(+), 3 deletions(-)
    >
    > diff --git a/drivers/usb/typec/tcpm/tcpci.c b/drivers/usb/typec/tcpm/tcpci.c
    > index b2bfcebe218f..d3efb9665901 100644
    > --- a/drivers/usb/typec/tcpm/tcpci.c
    > +++ b/drivers/usb/typec/tcpm/tcpci.c
    > @@ -807,8 +807,7 @@ void tcpci_unregister_port(struct tcpci *tcpci)
    > }
    > EXPORT_SYMBOL_GPL(tcpci_unregister_port);
    >
    > -static int tcpci_probe(struct i2c_client *client,
    > - const struct i2c_device_id *i2c_id)
    > +static int tcpci_probe(struct i2c_client *client)
    > {
    > struct tcpci_chip *chip;
    > int err;
    > @@ -878,7 +877,7 @@ static struct i2c_driver tcpci_i2c_driver = {
    > .name = "tcpci",
    > .of_match_table = of_match_ptr(tcpci_of_match),
    > },
    > - .probe = tcpci_probe,
    > + .probe_new = tcpci_probe,
    > .remove = tcpci_remove,
    > .id_table = tcpci_id,
    > };

    thanks,

    --
    heikki

    \
     
     \ /
      Last update: 2022-11-21 10:08    [W:4.025 / U:1.324 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site