lkml.org 
[lkml]   [2022]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 579/606] usb: typec: tcpm/fusb302: Convert to i2c's .probe_new()
    On Fri, Nov 18, 2022 at 11:45:13PM +0100, Uwe Kleine-König wrote:
    > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    >
    > The probe function doesn't make use of the i2c_device_id * parameter so it
    > can be trivially converted.
    >
    > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

    Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

    > ---
    > drivers/usb/typec/tcpm/fusb302.c | 5 ++---
    > 1 file changed, 2 insertions(+), 3 deletions(-)
    >
    > diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
    > index 721b2a548084..1ffce00d94b4 100644
    > --- a/drivers/usb/typec/tcpm/fusb302.c
    > +++ b/drivers/usb/typec/tcpm/fusb302.c
    > @@ -1677,8 +1677,7 @@ static struct fwnode_handle *fusb302_fwnode_get(struct device *dev)
    > return fwnode;
    > }
    >
    > -static int fusb302_probe(struct i2c_client *client,
    > - const struct i2c_device_id *id)
    > +static int fusb302_probe(struct i2c_client *client)
    > {
    > struct fusb302_chip *chip;
    > struct i2c_adapter *adapter = client->adapter;
    > @@ -1837,7 +1836,7 @@ static struct i2c_driver fusb302_driver = {
    > .pm = &fusb302_pm_ops,
    > .of_match_table = of_match_ptr(fusb302_dt_match),
    > },
    > - .probe = fusb302_probe,
    > + .probe_new = fusb302_probe,
    > .remove = fusb302_remove,
    > .id_table = fusb302_i2c_device_id,
    > };

    thanks,

    --
    heikki

    \
     
     \ /
      Last update: 2022-11-21 10:07    [W:4.049 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site