Messages in this thread | | | Date | Tue, 22 Nov 2022 07:18:05 +0900 | From | Masami Hiramatsu (Google) <> | Subject | Re: [PATCH 1/4] tracing/osnoise: Fix duration type |
| |
On Thu, 17 Nov 2022 14:46:17 +0100 Daniel Bristot de Oliveira <bristot@kernel.org> wrote:
> The duration type is a 64 long value, not an int. This was > causing some long noise to report wrong values. > > Change the duration to a 64 bits value.
This looks good to me.
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Thank you!
> > Fixes: bce29ac9ce0b ("trace: Add osnoise tracer") > Cc: Daniel Bristot de Oliveira <bristot@kernel.org> > Cc: Steven Rostedt <rostedt@goodmis.org> > Cc: Masami Hiramatsu <mhiramat@kernel.org> > Cc: Jonathan Corbet <corbet@lwn.net> > Signed-off-by: Daniel Bristot de Oliveira <bristot@kernel.org> > --- > kernel/trace/trace_osnoise.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/kernel/trace/trace_osnoise.c b/kernel/trace/trace_osnoise.c > index 78d536d3ff3d..4300c5dc4e5d 100644 > --- a/kernel/trace/trace_osnoise.c > +++ b/kernel/trace/trace_osnoise.c > @@ -917,7 +917,7 @@ void osnoise_trace_irq_entry(int id) > void osnoise_trace_irq_exit(int id, const char *desc) > { > struct osnoise_variables *osn_var = this_cpu_osn_var(); > - int duration; > + s64 duration; > > if (!osn_var->sampling) > return; > @@ -1048,7 +1048,7 @@ static void trace_softirq_entry_callback(void *data, unsigned int vec_nr) > static void trace_softirq_exit_callback(void *data, unsigned int vec_nr) > { > struct osnoise_variables *osn_var = this_cpu_osn_var(); > - int duration; > + s64 duration; > > if (!osn_var->sampling) > return; > @@ -1144,7 +1144,7 @@ thread_entry(struct osnoise_variables *osn_var, struct task_struct *t) > static void > thread_exit(struct osnoise_variables *osn_var, struct task_struct *t) > { > - int duration; > + s64 duration; > > if (!osn_var->sampling) > return; > -- > 2.32.0 >
-- Masami Hiramatsu (Google) <mhiramat@kernel.org>
| |