Messages in this thread | | | Date | Mon, 21 Nov 2022 13:57:08 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH RESEND] panic: Add register_panic_notifier and unregister_panic_notifier |
| |
On Sat, 19 Nov 2022 08:03:05 +0000 Xu Qiang <xuqiang36@huawei.com> wrote:
> Add two methods to manipulate panic_notifier_list and export them. > Subsequently, panic_notifier_list is changed to static variable.
Fair enough, I guess. But...
- It would be better to include a followup patch which converts at least some of the existing sites, so we know the code is getting tested.
- Better names would be panic_notifier_register() and panic_notifier_unregister()
- You forgot to make panic_notifier_list static to panic.c.
| |