Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [patch 10/15] timers: Silently ignore timers with a NULL function | Date | Mon, 21 Nov 2022 22:46:49 +0100 |
| |
On Mon, Nov 21 2022 at 16:35, Steven Rostedt wrote: > On Tue, 15 Nov 2022 21:28:49 +0100 (CET) > Thomas Gleixner <tglx@linutronix.de> wrote: >> @@ -1532,6 +1573,12 @@ static void expire_timers(struct timer_b >> >> fn = timer->function; >> >> + if (WARN_ON_ONCE(!fn)) { >> + /* Should never happen. Emphasis on should! */ >> + base->running_timer = NULL; >> + return; > > Why return and not continue? > > Wont this drop the other timers in the queue?
Duh. Yes. Thanks for catching that!
| |