Messages in this thread | | | Date | Mon, 21 Nov 2022 19:11:32 +0000 | From | Prashant Malani <> | Subject | Re: [PATCH] usb: typec: pd: Add symlink to linked device |
| |
Hi Greg,
On Nov 21 08:36, Greg Kroah-Hartman wrote: > On Mon, Nov 21, 2022 at 07:16:03AM +0000, Prashant Malani wrote: > > On Nov 21 07:35, Greg Kroah-Hartman wrote: > > > On Mon, Nov 21, 2022 at 06:20:39AM +0000, Prashant Malani wrote: > > Why either? What exactly is this "device" that you are trying to link > to? And why not just use the real device symlink instead?
It's the Type-C port partner device, created here [1]
> > > > > > > > What in userspace wants to see this symlink? > > > > ChromeOS's userspace Type-C daemon. It listens for Type-C partner uevents, but the PD objects > > can be created later (and destroyed and then recreated again, for PD chargers which dynamically > > change their source caps), and this helps determine which partner does those events apply to. > > Then set up the proper device symlink like the driver model supports, > then you don't have to create a new one, and you don't have to add the > documentation entry as it's implied.
Sounds good. I'll submit a new series (or single patch) which follows this approach.
Thanks again!
-Prashant
[1] https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/tree/drivers/usb/typec/class.c?h=usb-next#n885
| |