Messages in this thread | | | Date | Sun, 20 Nov 2022 12:22:31 +0100 | Subject | Re: [PATCH] ARM: s3c: Fix a build error after the s3c24xx dma driver was removed | From | Krzysztof Kozlowski <> |
| |
On 20/11/2022 11:31, Krzysztof Kozlowski wrote: > On 18/11/2022 22:54, Uwe Kleine-König wrote: >> The linux/platform_data/dma-s3c24xx.h header file was removed. It didn't >> declare or define any symbol needed in devs.c though, so the #include >> can just be dropped. >> >> Fixes: cccc46ae3623 ("dmaengine: remove s3c24xx driver") >> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> >> --- > > The file was not removed... or it should not have been yet. The s3c24xx > dma driver removal should be part of Arnd series taken via SoC ARM.
Also: I don't think the fix is correct. The header was used in mach-s3c, so removing the header should still cause broken build.
It also fails in other places:
arch/arm/mach-s3c/s3c24xx.c:21:10: fatal error: linux/platform_data/dma-s3c24xx.h: No such file or directory 21 | #include <linux/platform_data/dma-s3c24xx.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated.
I think that commit should be just dropped instead.
Best regards, Krzysztof
| |