[lkml]   [2022]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] tracing: Fix infinite loop in tracing_read_pipe on overflowed print_trace_line
On Fri, 18 Nov 2022 18:21:12 +0800
Yang Jihong <> wrote:

> > That way we can see the broken trace event and not just silently drop it.
> >
> Ok, will change in next version.(Because iter->seq.seq.len may be
> smaller than strlen(dots), direct subtraction here may not be appropriate.)

We should only need to do this if the len is maxed out.

Hmm, len is only updated if it did actually copy it.

Perhaps we could just add:

trace_seq_puts(&iter->seq, "[LINE TOO BIG]\n");

And perhaps that will work?

Anyway, what is triggering this?

-- Steve

 \ /
  Last update: 2022-11-20 20:52    [W:0.060 / U:1.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site