Messages in this thread |  | | From | Emil Renner Berthing <> | Date | Sun, 20 Nov 2022 19:33:42 +0100 | Subject | Re: [PATCH 5/7] riscv: dts: bouffalolab: add the bl808 SoC base device tree |
| |
On Sun, 20 Nov 2022 at 18:51, Conor Dooley <conor@kernel.org> wrote: > > On Sun, Nov 20, 2022 at 03:57:17PM +0100, Emil Renner Berthing wrote: > > On Sun, 20 Nov 2022 at 09:32, Jisheng Zhang <jszhang@kernel.org> wrote: > > > > > > Add a baisc dtsi for the bouffalolab bl808 SoC. > > > > + xtal: xtal-clk { > > > + compatible = "fixed-clock"; > > > + clock-frequency = <40000000>; > > > > This was discussed many times before, but I think the conclusion was > > that the frequency is a property of the crystal on the board, so this > > should be 0 in the SoC dtsi, and then overwritten in the board device > > tree. > > Or set nothing in soc.dtsi so that dtbs_check can be used to see if > someone forgot to set a clock for their board?
Sure. That sounds even better.
> > > + clock-output-names = "xtal"; > > > + #clock-cells = <0>; > > > + }; >
|  |