Messages in this thread Patch in this message | | | Date | Sun, 20 Nov 2022 12:39:11 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 08/12] perf test: Replace arm spe fork test workload with sqrtloop |
| |
Em Wed, Nov 16, 2022 at 03:38:50PM -0800, Namhyung Kim escreveu: > So that it can get rid of requirement of a compiler. I've also removed > killall as it'll kill perf process now and run the test workload for 10 > sec instead.
8 73.81 alpine:edge : FAIL gcc version 11.2.1 20220219 (Alpine 11.2.1_git20220219) tests/workloads/sqrtloop.c:23:3: error: ignoring return value of function declared with const attribute [-Werror,-Wunused-value] sqrt(rand()); ^~~~ ~~~~~~ 1 error generated. make[4]: *** [/git/perf-6.1.0-rc5/tools/build/Makefile.build:139: workloads] Error 2 make[3]: *** [/git/perf-6.1.0-rc5/tools/build/Makefile.build:139: tests] Error 2
I'll fix this one, probably just prepending a (void *).
- Arnaldo > Tested-by: Leo Yan <leo.yan@linaro.org> > Tested-by: James Clark <james.clark@arm.com> > Signed-off-by: Namhyung Kim <namhyung@kernel.org> > --- > tools/perf/tests/shell/test_arm_spe_fork.sh | 44 +-------------------- > 1 file changed, 1 insertion(+), 43 deletions(-) > > diff --git a/tools/perf/tests/shell/test_arm_spe_fork.sh b/tools/perf/tests/shell/test_arm_spe_fork.sh > index c920d3583d30..da810e1b2b9e 100755 > --- a/tools/perf/tests/shell/test_arm_spe_fork.sh > +++ b/tools/perf/tests/shell/test_arm_spe_fork.sh > @@ -11,14 +11,7 @@ skip_if_no_arm_spe_event() { > > skip_if_no_arm_spe_event || exit 2 > > -# skip if there's no compiler > -if ! [ -x "$(command -v cc)" ]; then > - echo "failed: no compiler, install gcc" > - exit 2 > -fi > - > -TEST_PROGRAM_SOURCE=$(mktemp /tmp/__perf_test.program.XXXXX.c) > -TEST_PROGRAM=$(mktemp /tmp/__perf_test.program.XXXXX) > +TEST_PROGRAM="perf test -w sqrtloop 10" > PERF_DATA=$(mktemp /tmp/__perf_test.perf.data.XXXXX) > PERF_RECORD_LOG=$(mktemp /tmp/__perf_test.log.XXXXX) > > @@ -27,43 +20,10 @@ cleanup_files() > echo "Cleaning up files..." > rm -f ${PERF_RECORD_LOG} > rm -f ${PERF_DATA} > - rm -f ${TEST_PROGRAM_SOURCE} > - rm -f ${TEST_PROGRAM} > } > > trap cleanup_files exit term int > > -# compile test program > -cat << EOF > $TEST_PROGRAM_SOURCE > -#include <math.h> > -#include <stdio.h> > -#include <stdlib.h> > -#include <unistd.h> > -#include <sys/wait.h> > - > -int workload() { > - while (1) > - sqrt(rand()); > - return 0; > -} > - > -int main() { > - switch (fork()) { > - case 0: > - return workload(); > - case -1: > - return 1; > - default: > - wait(NULL); > - } > - return 0; > -} > -EOF > - > -echo "Compiling test program..." > -CFLAGS="-lm" > -cc $TEST_PROGRAM_SOURCE $CFLAGS -o $TEST_PROGRAM || exit 1 > - > echo "Recording workload..." > perf record -o ${PERF_DATA} -e arm_spe/period=65536/ -vvv -- $TEST_PROGRAM > ${PERF_RECORD_LOG} 2>&1 & > PERFPID=$! > @@ -78,8 +38,6 @@ echo Log lines after 1 second = $log1 > > kill $PERFPID > wait $PERFPID > -# test program may leave an orphan process running the workload > -killall $(basename $TEST_PROGRAM) > > if [ "$log0" = "$log1" ]; > then > -- > 2.38.1.584.g0f3c55d4c2-goog
--
- Arnaldo
| |