Messages in this thread |  | | From | Emil Renner Berthing <> | Date | Sun, 20 Nov 2022 16:06:26 +0100 | Subject | Re: [PATCH 6/7] riscv: dts: bouffalolab: add Sipeed M1S dock devicetree |
| |
On Sun, 20 Nov 2022 at 09:33, Jisheng Zhang <jszhang@kernel.org> wrote: > > Sipeed manufactures a M1S system-on-module and dock board, add basic > support for them. > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org> > --- > arch/riscv/boot/dts/bouffalolab/Makefile | 2 ++ > .../boot/dts/bouffalolab/bl808-sipeed-m1s.dts | 30 +++++++++++++++++++ > 2 files changed, 32 insertions(+) > create mode 100644 arch/riscv/boot/dts/bouffalolab/Makefile > create mode 100644 arch/riscv/boot/dts/bouffalolab/bl808-sipeed-m1s.dts > > diff --git a/arch/riscv/boot/dts/bouffalolab/Makefile b/arch/riscv/boot/dts/bouffalolab/Makefile > new file mode 100644 > index 000000000000..42e17e1a97bd > --- /dev/null > +++ b/arch/riscv/boot/dts/bouffalolab/Makefile > @@ -0,0 +1,2 @@ > +# SPDX-License-Identifier: GPL-2.0 > +dtb-$(CONFIG_SOC_BOUFFALOLAB) += bl808-sipeed-m1s.dtb > diff --git a/arch/riscv/boot/dts/bouffalolab/bl808-sipeed-m1s.dts b/arch/riscv/boot/dts/bouffalolab/bl808-sipeed-m1s.dts > new file mode 100644 > index 000000000000..64421fb2ad67 > --- /dev/null > +++ b/arch/riscv/boot/dts/bouffalolab/bl808-sipeed-m1s.dts > @@ -0,0 +1,30 @@ > +// SPDX-License-Identifier: (GPL-2.0+ or MIT) > +/* > + * Copyright (C) 2022 Jisheng Zhang <jszhang@kernel.org> > + */ > + > +/dts-v1/; > + > +#include "bl808.dtsi" > + > +/ { > + model = "Sipeed M1S";
On seeedstudio.com and everywhere else I look I only see this written as "Sipeed M1s".
And to echo what Icenowy writes, this is better split as a .dtsi for the Sipeed M1s module that can then be included by a .dts for the using the module with the dock, which should then have something like
model = "Sipeed M1s Dock";
> + compatible = "sipeed,m1s", "bouffalolab,bl808"; > + > + aliases { > + serial0 = &uart0; > + }; > + > + chosen { > + stdout-path = "serial0:2000000n8"; > + }; > + > + memory@50000000 { > + device_type = "memory"; > + reg = <0x50000000 0x04000000>; > + }; > +}; > + > +&uart0 { > + status = "okay"; > +}; > --- > 2.37.2 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv
|  |