Messages in this thread |  | | Date | Sun, 20 Nov 2022 06:14:32 -0800 | From | Guenter Roeck <> | Subject | Re: [PATCH v3] hwmon: (pmbus/core): Implement regulator get_status |
| |
On Sat, Nov 19, 2022 at 07:25:16PM +0100, Naresh Solanki wrote: > From: Patrick Rudolph <patrick.rudolph@9elements.com> > > Add get_status for pmbus_regulator_ops. > > Changes: > - use lock throughout the function > - Avoid line continuation upto 100 column > - Optimize use of & and | operator > - Check for VOUT, IOUT, TEMPERATURE bit in status word before checking > respective status register for fault. > - Report regulator current status. > Change log should be after '---'
Also, when looking into this, I realized that we already have pmbus_regulator_get_error_flags() which has somewhat overlapping functionality. Would it be possible to utilize that function to get the error status instead of more or less hand-coding it ?
Thanks, Guenter
|  |