Messages in this thread | | | From | Daniel Latypov <> | Date | Wed, 2 Nov 2022 10:38:04 -0700 | Subject | Re: [PATCH] perf/hw_breakpoint: test: Skip the test if dependencies unmet |
| |
On Wed, Nov 2, 2022 at 3:23 AM Marco Elver <elver@google.com> wrote: > > Hi David, Daniel, > > On Wed, 26 Oct 2022 at 20:31, Daniel Latypov <dlatypov@google.com> wrote: > [...] > > > - return -EINVAL; > > > + kunit_skip(test, "not enough cpus"); > > > > The only minor nit I have is that I'd personally prefer something like > > kunit_skip(test, "need >=2 cpus"); > > since that makes it clearer > > a) that we must only have 1 CPU by default > > b) roughly how one might address this. > > > > Note: b) is a bit more complicated than I would like. The final > > command is something like > > $ ./tools/testing/kunit/kunit.py run --arch x86_64 --qemu_args='-smp > > 2' --kconfig_add='CONFIG_SMP=y' > > > > But that's orthogonal to this patch. > > Was there going to be a v2 to address (a), or is this patch ready to > be picked up? > > I assume (unless I hear otherwise), this patch shall also go through -tip?
Just noting for the record: I'm totally fine with this version going in, esp. if Peter is already planning on picking it up.
This patch makes it so `kunit.py run --arch=x86_64` doesn't have test failures, so I don't want it delayed due to just my small nit.
Daniel
| |