lkml.org 
[lkml]   [2022]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v5 1/4] ccp: Name -1 return value as SEV_RET_NO_FW_CALL
From
On 11/2/22 10:43, Peter Gonda wrote:
> From: Dionna Glaze <dionnaglaze@google.com>
>
> The PSP can return a "firmware error" code of -1 in circumstances where
> the PSP is not actually called. To make this protocol unambiguous, we
> add a constant naming the return value.
>
> From: Peter Gonda <pgonda@google.com>
> Cc: Thomas Lendacky <Thomas.Lendacky@amd.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Joerg Roedel <jroedel@suse.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Andy Lutomirsky <luto@kernel.org>
>
> Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
>
> I think you can modify the author of this commit to be 'Peter Gonda
> <pgonda@google.com>' then include my Signed-off-by.
>

Since you have to resend for the proper Signed-off-by: chain, the subject
line should really be: crypto: ccp - Name -1 ...

and you missed copying the other CCP driver maintainer.

It's always good to do a git log on the file(s) you're updating to get an
idea of the appropriate prefix to use.

Thanks,
Tom

>

\
 
 \ /
  Last update: 2022-11-02 18:31    [W:0.474 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site