Messages in this thread | | | Date | Wed, 2 Nov 2022 12:19:25 -0400 | Subject | Re: [PATCH 1/2] dt-bindings: leds-lp55xx: add ti,disable-charge-pump | From | Krzysztof Kozlowski <> |
| |
On 29/10/2022 03:48, Maarten Zanders wrote: > > On 10/29/22 00:07, Krzysztof Kozlowski wrote: >> Drop | > OK. >>> + Disable the internal charge pump. >> Does it mean that it is enabled by default? > > The device default after reset is "off". > The current implementation sets it to "auto". > Other possible modes are "bypass" and "boost". > > Should I change to an optional "ti,charge_pump_mode" as string and set > default to "auto"?
enum makes more sense in that case. Just don't user underscores in property names.
Best regards, Krzysztof
| |