lkml.org 
[lkml]   [2022]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/2] dt-bindings: leds-lp55xx: add ti,disable-charge-pump
From
On 29/10/2022 03:48, Maarten Zanders wrote:
>
> On 10/29/22 00:07, Krzysztof Kozlowski wrote:
>> Drop |
> OK.
>>> + Disable the internal charge pump.
>> Does it mean that it is enabled by default?
>
> The device default after reset is "off".
> The current implementation sets it to "auto".
> Other possible modes are "bypass" and "boost".
>
> Should I change to an optional "ti,charge_pump_mode" as string and set
> default to "auto"?

enum makes more sense in that case. Just don't user underscores in
property names.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-11-02 17:26    [W:1.259 / U:1.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site