lkml.org 
[lkml]   [2022]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/8] iio: gyro: adis16136: Fix deadlock in probe
    Date
    Use __adis_initial_startup instead of adis_initial_startup to
    avoid deadlock.
    When using adis_initial_startup mutex_lock is called twice,
    without releasing it (once inside adis_initial_startup and
    once inside adis_enable_irq).

    Fixes: 100bfa38c8cb ("iio: imu: adis[16480]: group RW into a single lock in adis_enable_irq()")
    Signed-off-by: Ramona Bolboaca <ramona.bolboaca@analog.com>
    ---
    drivers/iio/gyro/adis16136.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/iio/gyro/adis16136.c b/drivers/iio/gyro/adis16136.c
    index 71295709f2b9..c95cf41be34b 100644
    --- a/drivers/iio/gyro/adis16136.c
    +++ b/drivers/iio/gyro/adis16136.c
    @@ -429,7 +429,7 @@ static int adis16136_initial_setup(struct iio_dev *indio_dev)
    uint16_t prod_id;
    int ret;

    - ret = adis_initial_startup(&adis16136->adis);
    + ret = __adis_initial_startup(&adis16136->adis);
    if (ret)
    return ret;

    --
    2.25.1
    \
     
     \ /
      Last update: 2022-11-02 15:21    [W:4.946 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site