lkml.org 
[lkml]   [2022]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/2] dt-bindings: regulator: Add bindings for Richtek RT6190 regulator
On Mon, Oct 31, 2022 at 10:28:53AM +0800, cy_huang wrote:
> From: ChiYuan Huang <cy_huang@richtek.com>
>
> Add devicetree binding for Richtek RT6190 4-Switch buckboost controller.
>
> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> ---
> Hi, Rob:
>
> Since I didn't got any reply from the v2 dt-binding question.
> https://lore.kernel.org/lkml/CADiBU3_WUeyYdnmnG0Ff2pH+b3u1zOtP1z44LcA53Ba5c9nrEw@mail.gmail.com/
> In v3, I aleady fixed it following by your comment.
>
> I'm just wondering the corrent usage.
> As I know, 'enable-gpios' comes from 'gpio-consumer-common.yaml'.
> In the common yaml file, it's already declared 'enable-gpios' maxItems as '1'.
> That's why I just declared it as 'true'.

Yes, you are right. Either way is fine then.

> Since v3:
> - Fix the typo 'upply' to 'supply'.
> - Declare 'enable-gpios' maxItems as 1.
> - Declare the 'maxItems' for the property 'regulator-allowed-modes'.
>
> Since v2:
> - Rename binding filename to 'richtek,rt6190.yaml'
>
> ---
> .../bindings/regulator/richtek,rt6190.yaml | 79 ++++++++++++++++++++++
> 1 file changed, 79 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/regulator/richtek,rt6190.yaml

Reviewed-by: Rob Herring <robh@kernel.org>

\
 
 \ /
  Last update: 2022-11-02 15:07    [W:0.082 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site