Messages in this thread | | | Date | Wed, 2 Nov 2022 14:02:39 +0100 | From | "Jason A. Donenfeld" <> | Subject | Re: [PATCH] soc: ux500: do not directly dereference __iomem |
| |
CC+ Arnd
On Sun, Oct 30, 2022 at 11:30:46PM +0100, Jason A. Donenfeld wrote: > Hi Linus, > > On Sun, Oct 23, 2022 at 9:57 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote: > > > > Sparse reports that calling add_device_randomness() on `uid` is a > > violation of address spaces. And indeed the next usage uses readl() > > properly, but that was left out when passing it toadd_device_ > > randomness(). So instead copy the whole thing to the stack first. > > > > Fixes: 4040d10a3d44 ("ARM: ux500: add DB serial number to entropy pool") > > Cc: Linus Walleij <linus.walleij@linaro.org> > > Cc: stable@vger.kernel.org > > Link: https://lore.kernel.org/all/202210230819.loF90KDh-lkp@intel.com/ > > Reported-by: kernel test robot <lkp@intel.com> > > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> > > Just thought I'd follow up on this.
| |