Messages in this thread | | | Date | Wed, 2 Nov 2022 14:02:42 +0300 | Subject | Re: [PATCH v2 2/2] drm/client: Prevent NULL dereference in drm_client_buffer_delete() | From | Dmitry Osipenko <> |
| |
On 11/2/22 12:15, Christian König wrote: > Am 30.10.22 um 16:44 schrieb Dmitry Osipenko: >> The drm_gem_vunmap() will crash with a NULL dereference if the passed >> object pointer is NULL. It wasn't a problem before we added the locking >> support to drm_gem_vunmap function because the mapping argument was >> always >> NULL together with the object. Make drm_client_buffer_delete() to check >> whether GEM is NULL before trying to unmap the GEM, it will happen on >> framebuffer creation error. >> >> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> >> Link: https://lore.kernel.org/dri-devel/Y1kFEGxT8MVlf32V@kili/ >> Fixes: 79e2cf2e7a19 ("drm/gem: Take reservation lock for vmap/vunmap >> operations") >> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com> > > Reviewed-by: Christian König <christian.koenig@amd.com>
Applied to drm-misc-next, thanks!
-- Best regards, Dmitry
| |