lkml.org 
[lkml]   [2022]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v6 13/21] gunyah: vm_mgr: Introduce basic VM Manager
    On Wed, Oct 26, 2022 at 11:58:38AM -0700, Elliot Berman wrote:
    > +#define GH_CREATE_VM _IO(GH_IOCTL_TYPE, 0x40) /* Returns a Gunyah VM fd */

    Why 0x40? Why not just use the same KVM ioctl numbers and names as you
    are doing the same thing as them, right?

    Normally your first ioctl is "0x01", not "0x40", so this feels really
    odd.

    thanks,

    greg k-h

    \
     
     \ /
      Last update: 2022-11-02 06:14    [W:3.036 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site