Messages in this thread | | | Date | Wed, 2 Nov 2022 10:16:13 +0100 | Subject | Re: [PATCH 2/2] mm: Use pte markers for swap errors | From | David Hildenbrand <> |
| |
On 30.10.22 22:41, Peter Xu wrote: > PTE markers are ideal mechanism for things like SWP_SWAPIN_ERROR. Using a > whole swap entry type for this purpose can be an overkill, especially if we > already have PTE markers. Define a new bit for swapin error and replace it > with pte markers. Then we can safely drop SWP_SWAPIN_ERROR and give one > device slot back to swap. > > We used to have SWP_SWAPIN_ERROR taking the page pfn as part of the swap > entry, but it's never used. Neither do I see how it can be useful because > normally the swapin failure should not be caused by a bad page but bad swap > device. Drop it alongside. > > Reviewed-by: Huang Ying <ying.huang@intel.com> > Reviewed-by: Miaohe Lin <linmiaohe@huawei.com> > Signed-off-by: Peter Xu <peterx@redhat.com> > ---
Acked-by: David Hildenbrand <david@redhat.com>
-- Thanks,
David / dhildenb
| |