Messages in this thread | | | Date | Wed, 2 Nov 2022 20:36:40 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH net-next v2 1/2] net: hinic: Convert the cmd code from decimal to hex to be more readable |
| |
On Tue, 1 Nov 2022 14:03:38 +0800 Cai Huoqing wrote: > The print cmd code is in hex, so using hex cmd code intead of > decimal is easy to check the value with print info.
You're still removing empty lines making this patch much harder to review. Once again - it should be a pure conversion to dec -> hex. Don't make any other changes.
| |