Messages in this thread | | | Subject | Re: [PATCH] mm: hugetlb_vmemmap: include missing linux/moduleparam.h | From | Muchun Song <> | Date | Thu, 3 Nov 2022 10:51:59 +0800 |
| |
> On Nov 3, 2022, at 02:09, Vasily Gorbik <gor@linux.ibm.com> wrote: > > The kernel test robot reported build failures with a 'randconfig' on s390: >>> mm/hugetlb_vmemmap.c:421:11: error: a function declaration without a > prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] > core_param(hugetlb_free_vmemmap, vmemmap_optimize_enabled, bool, 0); > ^ > > Link: https://lore.kernel.org/linux-mm/202210300751.rG3UDsuc-lkp@intel.com/ > Reported-by: kernel test robot <lkp@intel.com> > Fixes: 30152245c63b ("mm: hugetlb_vmemmap: replace early_param() with core_param()")
Thanks for your fixing. However, the correct commit that should be fixed is 42deddf3ef5c ("s390: select ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP").
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
| |