lkml.org 
[lkml]   [2022]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 0/2] staging: rtl8192u: unused code cleanup
On Mon, Oct 31, 2022 at 11:25:14PM +0530, Deepak R Varma wrote:
> Remove unnecessary or unused code.
>
> Changes in v2:
> Patch1:
> 1. Revise patch log to explain impact of the patch
> Suggested by gregkh@linuxfoundation.org
> Patch2:
> 1. Review other similar macro defines and clean those up as well.
> Suggested by gregkh@linuxfoundation.org
> 2. Revise patch log to explain impact of the patch
> Suggested by julia.lawall@inria.fr
>
> Deepak R Varma (2):
> staging: rtl8192u: remove unnecessary function implementation
> staging: rtl8192u: remove redundant macro definition
>
> .../staging/rtl8192u/ieee80211/ieee80211.h | 67 -------------------
> .../rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 6 --
> .../rtl8192u/ieee80211/ieee80211_module.c | 3 -
> 3 files changed, 76 deletions(-)

This series causes a build breakage:

MODPOST Module.symvers
../ERROR: modpost: net/mac80211/mac80211: 'ieee80211_wake_queue' exported twice. Previous export was in drivers/staging/rtl8192u/r8192u_usb.ko
ERROR: modpost: net/mac80211/mac80211: 'ieee80211_stop_queue' exported twice. Previous export was in drivers/staging/rtl8192u/r8192u_usb.ko
make[1]: *** [scripts/Makefile.modpost:126: Module.symvers] Error 1
make: *** [Makefile:1944: modpost] Error 2

Always test build your changes.

greg k-h

\
 
 \ /
  Last update: 2022-11-02 08:27    [W:0.101 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site