Messages in this thread | | | Date | Wed, 2 Nov 2022 21:44:36 +0100 | Subject | Re: [PATCH 4/4] arm64: dts: qcom: add sdm670 and pixel 3a device trees | From | Konrad Dybcio <> |
| |
On 02/11/2022 21:30, Krzysztof Kozlowski wrote: > On 02/11/2022 16:26, Konrad Dybcio wrote: >> On 02/11/2022 00:57, Richard Acayan wrote: >>> The Qualcomm Snapdragon 670 has been out for a while. Add a device tree >>> for it and the Google Pixel 3a as the first device. >>> >>> The Pixel 3a has the same bootloader issue as the Pixel 3 and will not work >>> on Android 10 bootloaders or later until it gets fixed for the Pixel 3. >>> >>> SoC Initial Features: >>> - power management >>> - clocks >>> - pinctrl >>> - eMMC >>> - USB 2.0 >>> - GENI I2C >>> - IOMMU >>> - RPMh >>> - interrupts >>> >>> Device-Specific Initial Features: >>> - side buttons (keys) >>> - regulators >>> - touchscreen >>> >>> Signed-off-by: Richard Acayan <mailingradian@gmail.com> >>> --- >>> arch/arm64/boot/dts/qcom/Makefile | 1 + >>> .../boot/dts/qcom/sdm670-google-sargo.dts | 519 +++++++ >>> arch/arm64/boot/dts/qcom/sdm670.dtsi | 1216 +++++++++++++++++ >>> 3 files changed, 1736 insertions(+) >>> create mode 100644 arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts >>> create mode 100644 arch/arm64/boot/dts/qcom/sdm670.dtsi >>> >>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile >>> index b0558d3389e5..4eb5d8829efb 100644 >>> --- a/arch/arm64/boot/dts/qcom/Makefile >>> +++ b/arch/arm64/boot/dts/qcom/Makefile >>> @@ -124,6 +124,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sdm630-sony-xperia-nile-voyager.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += sdm632-fairphone-fp3.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += sdm636-sony-xperia-ganges-mermaid.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += sdm660-xiaomi-lavender.dtb >>> +dtb-$(CONFIG_ARCH_QCOM) += sdm670-google-sargo.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r1.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r2.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r3.dtb >>> diff --git a/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts b/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts >>> new file mode 100644 >>> index 000000000000..fa3dee78e442 >>> --- /dev/null >>> +++ b/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts >>> @@ -0,0 +1,519 @@ >>> +// SPDX-License-Identifier: GPL-2.0 >>> +/* >>> + * Device tree for Google Pixel 3a, adapted from google-blueline device tree, >>> + * xiaomi-lavender device tree, and oneplus-common device tree. >>> + * >>> + * Copyright (c) 2022, Richard Acayan. All rights reserved. >>> + */ >>> + >>> +/dts-v1/; >>> + >>> +#include <dt-bindings/gpio/gpio.h> >>> +#include <dt-bindings/input/input.h> >>> +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h> >>> +#include <dt-bindings/power/qcom-rpmpd.h> >>> +#include "sdm670.dtsi" >>> +#include "pm660.dtsi" >>> +#include "pm660l.dtsi" >>> + >>> +/delete-node/ &mpss_region; >>> +/delete-node/ &venus_mem; >>> +/delete-node/ &wlan_msa_mem; >>> +/delete-node/ &cdsp_mem; >>> +/delete-node/ &mba_region; >>> +/delete-node/ &adsp_mem; >>> +/delete-node/ &ipa_fw_mem; >>> +/delete-node/ &ipa_gsi_mem; >>> +/delete-node/ &gpu_mem; >>> + >>> +/ { >>> + model = "Google Pixel 3a"; >>> + compatible = "google,sargo", "qcom,sdm670"; >>> + qcom,board-id = <0x00041e05 0>; >>> + qcom,msm-id = <321 0x20001>; >>> + >>> + aliases { }; >>> + >>> + chosen { >>> + stdout-path = "serial0:115200n8"; >>> + >>> + #address-cells = <2>; >>> + #size-cells = <2>; >>> + ranges; >>> + >>> + framebuffer@9c000000 { >>> + compatible = "simple-framebuffer"; >>> + reg = <0x0 0x9c000000 0x0 (1080 * 2220 * 4)>; >>> + width = <1080>; >>> + height = <2220>; >>> + stride = <(1080 * 4)>; >>> + format = "a8r8g8b8"; >>> + }; >>> + }; >>> + >>> + reserved-memory { >>> + #address-cells = <2>; >>> + #size-cells = <2>; >>> + >>> + mpss_region: mpss@8b000000 { >> Please call the nodes memory@ > I think the actual recommendation is to use the purpose as name: > > https://lore.kernel.org/linux-arm-msm/CAL_Jsq+66j8Y5y+PQ+mezkaxN1pfHFKz524YUF4Lz_OU5E-mZQ@mail.gmail.com/ > > https://devicetree-specification.readthedocs.io/en/latest/chapter3-devicenodes.html#reserved-memory-child-nodes > (second paragraph)
Ok, my bad.
Konrad
> > > Best regards, > Krzysztof >
| |