Messages in this thread | | | Date | Wed, 2 Nov 2022 19:55:58 +0100 | Subject | Re: [PATCH 0/9] thermal/core: Protect thermal device operations against removal | From | Daniel Lezcano <> |
| |
On 02/11/2022 19:50, Guenter Roeck wrote: > Hi, > > On Mon, Oct 17, 2022 at 06:09:01AM -0700, Guenter Roeck wrote: >> Accesses to thermal zones, and with it to thermal zone device operations, >> are still possible after the thermal zone device has been unregistered. >> For example, thermal_zone_get_temp() can be called from temp_show() >> in thermal_sysfs.c if the sysfs attribute was opened before the thermal >> device was unregistered. This is problematic and may result in crashes >> since the operations data structure and the underlying code may be gone >> when the calls are made. >> >> The following series solves the problem by protecting accesses to thermal >> device operations with the thermal device mutex, and by verifying that the >> thermal device is still registered after the mutex has been acquired. >> >> This was previously sent as RFC/RFT as single patch [1]. The code was reworked >> to match thermal subsystem changes made between v6.0 and v6.1, and it was >> split into several patches to simplify review. >> > > Any thoughts / comments / feedback on this series ?
I'm out of the office ATM, I'll have a look on the series in a few days.
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |